[webkit-reviews] review granted: [Bug 184017] [ASan] Allow Ref<> to be swapped : [Attachment 336529] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 26 11:35:23 PDT 2018
Antti Koivisto <koivisto at iki.fi> has granted Antoine Quint
<graouts at apple.com>'s request for review:
Bug 184017: [ASan] Allow Ref<> to be swapped
https://bugs.webkit.org/show_bug.cgi?id=184017
Attachment 336529: Patch
https://bugs.webkit.org/attachment.cgi?id=336529&action=review
--- Comment #4 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 336529
--> https://bugs.webkit.org/attachment.cgi?id=336529
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=336529&action=review
> Source/WTF/wtf/Ref.h:173
> +#if ASAN_ENABLED
> + if (__asan_address_is_poisoned(this))
> + __asan_unpoison_memory_region(this, sizeof(*this));
> +#endif
> Ref movedReference = WTFMove(reference);
Too much indentation.
> Source/WTF/wtf/Ref.h:185
> +#if ASAN_ENABLED
> + if (__asan_address_is_poisoned(this))
> + __asan_unpoison_memory_region(this, sizeof(*this));
> +#endif
Here too.
More information about the webkit-reviews
mailing list