[webkit-reviews] review granted: [Bug 183935] [Web Animations] Correctly handle timing functions specified by CSS Animations and CSS Transitions : [Attachment 336374] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 183935: [Web Animations] Correctly handle timing functions specified by CSS
Animations and CSS Transitions
https://bugs.webkit.org/show_bug.cgi?id=183935

Attachment 336374: Patch

https://bugs.webkit.org/attachment.cgi?id=336374&action=review




--- Comment #5 from Dean Jackson <dino at apple.com> ---
Comment on attachment 336374
  --> https://bugs.webkit.org/attachment.cgi?id=336374
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336374&action=review

> Source/WebCore/animation/KeyframeEffectReadOnly.cpp:529
> +	       // For CSS transitions, there are only two keyframes and the
second keyframe should always report "linear". In practice, this value
> +	       // has no bearing since, as the last keyframe, its value will
never be used.
> +	       computedKeyframe.easing = is<CSSTransition>(animation()) && i ==
1 ? "linear" : timingFunctionForKeyframeAtIndex(0)->cssText();

I know this doesn't matter in this case, but I believe "ease" should be the
default.