[webkit-reviews] review granted: [Bug 183969] Use SecurityOriginData more consistently in Service Worker code : [Attachment 336475] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 183969: Use SecurityOriginData more consistently in Service Worker code
https://bugs.webkit.org/show_bug.cgi?id=183969

Attachment 336475: Patch

https://bugs.webkit.org/attachment.cgi?id=336475&action=review




--- Comment #17 from Darin Adler <darin at apple.com> ---
Comment on attachment 336475
  --> https://bugs.webkit.org/attachment.cgi?id=336475
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336475&action=review

> Source/WebCore/page/SecurityOriginData.cpp:47
> +    return makeString(protocol, "://", host, ':', String::number(*port));

Calling String::number should not be necessary if we include the
StringConcatenateNumbers.h header, and that would save allocating and then
destroying a String every time.