[webkit-reviews] review granted: [Bug 183978] Adopt WK_PLATFORM_NAME in WebKit : [Attachment 336467] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Tim Horton <thorton at apple.com>'s request for
review:
Bug 183978: Adopt WK_PLATFORM_NAME in WebKit
https://bugs.webkit.org/show_bug.cgi?id=183978

Attachment 336467: Patch

https://bugs.webkit.org/attachment.cgi?id=336467&action=review




--- Comment #2 from mitz at webkit.org ---
Comment on attachment 336467
  --> https://bugs.webkit.org/attachment.cgi?id=336467
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336467&action=review

> Source/WebKit/Configurations/WebKit.xcconfig:40
> +WK_WEAK_FRAMEWORK_ON_MAC = $(WK_WEAK_FRAMEWORK_ON_MAC_$(WK_COCOA_TOUCH));

Following the convention in other Apple projects this would be called
WK_MACOS_WEAK_FRAMEWORK and go in Base.xcconfig.