[webkit-reviews] review granted: [Bug 183966] Use completion handlers for ResourceHandleClient::canAuthenticateAgainstProtectionSpaceAsync : [Attachment 336446] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Mar 23 20:19:47 PDT 2018
Chris Dumez <cdumez at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 183966: Use completion handlers for
ResourceHandleClient::canAuthenticateAgainstProtectionSpaceAsync
https://bugs.webkit.org/show_bug.cgi?id=183966
Attachment 336446: Patch
https://bugs.webkit.org/attachment.cgi?id=336446&action=review
--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 336446
--> https://bugs.webkit.org/attachment.cgi?id=336446
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=336446&action=review
r=me with fix
>
Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOpe
rationQueue.cpp:366
> + auto completionHandler = [protectedThis = WTFMove(protectedThis)]
(bool result) mutable {
You WTFMove() protectedThis here...
>
Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOpe
rationQueue.cpp:371
> + if (!protectedThis->hasHandle())
...but use it here
More information about the webkit-reviews
mailing list