[webkit-reviews] review granted: [Bug 183960] Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKitLegacy and update install name : [Attachment 336439] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Tim Horton <thorton at apple.com>'s request for
review:
Bug 183960: Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKitLegacy and update
install name
https://bugs.webkit.org/show_bug.cgi?id=183960

Attachment 336439: Patch

https://bugs.webkit.org/attachment.cgi?id=336439&action=review




--- Comment #3 from mitz at webkit.org ---
Comment on attachment 336439
  --> https://bugs.webkit.org/attachment.cgi?id=336439
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336439&action=review

> Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig:68
> +DYLIB_INSTALL_NAME_BASE = $(DYLIB_INSTALL_NAME_BASE_PLATFORM);
> +DYLIB_INSTALL_NAME_BASE_PLATFORM[sdk=iphone*] =
$(SYSTEM_LIBRARY_DIR)/PrivateFrameworks;
> +DYLIB_INSTALL_NAME_BASE_PLATFORM[sdk=macosx*] =
$(DYLIB_INSTALL_NAME_BASE_PLATFORM_$(WK_USE_ALTERNATE_FRAMEWORKS_DIR));
> +DYLIB_INSTALL_NAME_BASE_PLATFORM_NO =
$(NORMAL_WEBKIT_LEGACY_FRAMEWORKS_DIR);
> +DYLIB_INSTALL_NAME_BASE_PLATFORM_YES = $(DYLIB_INSTALL_NAME_BASE);

This seems unnecessarily complicated and fragile (in case of an SDK that
doesn’t match iphone* nor macosx*).