[webkit-reviews] review granted: [Bug 183911] Warn against cookie access in the WebContent process using ProcessPrivilege assertions : [Attachment 336433] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 23 15:41:17 PDT 2018


youenn fablet <youennf at gmail.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 183911: Warn against cookie access in the WebContent process using
ProcessPrivilege assertions
https://bugs.webkit.org/show_bug.cgi?id=183911

Attachment 336433: Patch

https://bugs.webkit.org/attachment.cgi?id=336433&action=review




--- Comment #11 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 336433
  --> https://bugs.webkit.org/attachment.cgi?id=336433
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336433&action=review

> Source/WebKit/UIProcess/WebProcessPool.cpp:248
> +    WebCore::NetworkStorageSession::permitProcessToUseCookieAPI(true);

We could probably use std::call_once here.
Is it soon enough though?
Can there be a way to use some Cookie API that would need that permission
before creating a WebProcessPool?


More information about the webkit-reviews mailing list