[webkit-reviews] review granted: [Bug 69138] Local storage getItem() for an empty string returned UNDEFINED value. : [Attachment 336360] Patch

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 69138: Local storage getItem() for an empty string returned UNDEFINED
value.
https://bugs.webkit.org/show_bug.cgi?id=69138

Attachment 336360: Patch

https://bugs.webkit.org/attachment.cgi?id=336360&action=review




--- Comment #51 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 336360
  --> https://bugs.webkit.org/attachment.cgi?id=336360
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336360&action=review

> Source/WebCore/platform/sql/SQLiteStatement.cpp:386
> +    if (sqlite3_errcode(m_database.sqlite3Handle()) != SQLITE_OK)

Instead of calling sqlite3_errcode on the sqlite3 handle, just call
m_database.lastError()