[webkit-reviews] review granted: [Bug 183796] Lint web-platform-tests changes with the wpt linter before exporting : [Attachment 336399] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 23 13:58:54 PDT 2018


youenn fablet <youennf at gmail.com> has granted Brendan McLoughlin
<brendan at bocoup.com>'s request for review:
Bug 183796: Lint web-platform-tests changes with the wpt linter before
exporting
https://bugs.webkit.org/show_bug.cgi?id=183796

Attachment 336399: Patch

https://bugs.webkit.org/attachment.cgi?id=336399&action=review




--- Comment #17 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 336399
  --> https://bugs.webkit.org/attachment.cgi?id=336399
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336399&action=review

> Tools/Scripts/webkitpy/w3c/test_exporter_unittest.py:117
> +	       mock_linter = self

We should probably empty self.calls otherwise it will grow for each sub test.


More information about the webkit-reviews mailing list