[webkit-reviews] review granted: [Bug 183924] Add support for VCP encoder on MacOS and iOS : [Attachment 336330] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 183924: Add support for VCP encoder on MacOS and iOS
https://bugs.webkit.org/show_bug.cgi?id=183924

Attachment 336330: Patch

https://bugs.webkit.org/attachment.cgi?id=336330&action=review




--- Comment #5 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 336330
  --> https://bugs.webkit.org/attachment.cgi?id=336330
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336330&action=review

>
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/VideoProcessingSoftLink.cp
p:74
> +SOFT_LINK_FUNCTION_FOR_SOURCE(webrtc, VideoProcessing,
VCPCompressionSessionEncodeFrame, OSStatus, (VCPCompressionSessionRef session,
CVImageBufferRef buffer, CMTime timestamp, CMTime time, CFDictionaryRef
dictionary, void * data, VTEncodeInfoFlags * flags), (session, buffer,
timestamp, time, dictionary, data, flags))
> +SOFT_LINK_FUNCTION_FOR_SOURCE(webrtc, VideoProcessing,
VCPCompressionSessionCreate, OSStatus, (CFAllocatorRef allocator1, int32_t
value1 , int32_t value2, CMVideoCodecType type, CFDictionaryRef dictionary1,
CFDictionaryRef dictionary2, CFAllocatorRef allocator3,
VTCompressionOutputCallback callback, void * data, VCPCompressionSessionRef
*session), (allocator1, value1, value2, type, dictionary1, dictionary2,
allocator3, callback, data, session))

Nit: shouldn't have spaces on both sides of the "*"s