[webkit-reviews] review granted: [Bug 183944] [Extra zoom mode] Adopt list view controller UI for select menus : [Attachment 336390] Patch

[bugzilla-daemon at webkit.org]

Andy Estes <aestes at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 183944: [Extra zoom mode] Adopt list view controller UI for select menus
https://bugs.webkit.org/show_bug.cgi?id=183944

Attachment 336390: Patch

https://bugs.webkit.org/attachment.cgi?id=336390&action=review




--- Comment #2 from Andy Estes <aestes at apple.com> ---
Comment on attachment 336390
  --> https://bugs.webkit.org/attachment.cgi?id=336390
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336390&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:4221
> +    _selectMenuListViewController = adoptNS([[WKSelectMenuListViewController
alloc] initWithDelegate:self]);
> +    [_selectMenuListViewController setDelegate:self];

Do you really need to call -initWithDelegate: and -setDelegate:?