[webkit-reviews] review granted: [Bug 183918] [Web Animations] Animated transform styles are ignored when calling getComputedStyle() : [Attachment 336362] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 183918: [Web Animations] Animated transform styles are ignored when calling
getComputedStyle()
https://bugs.webkit.org/show_bug.cgi?id=183918

Attachment 336362: Patch

https://bugs.webkit.org/attachment.cgi?id=336362&action=review




--- Comment #13 from Dean Jackson <dino at apple.com> ---
Comment on attachment 336362
  --> https://bugs.webkit.org/attachment.cgi?id=336362
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336362&action=review

> Source/WebCore/ChangeLog:16
> +	   Strictly looking at whether the renderer has a transform is a bad
idea when determining whether a
> +	   transform is applied for an element. Looking at the RenderStyle is
preferable because in the case
> +	   of animations running on the compositor, such as a transform-only
animation or transition, the
> +	   renderer doesn't necessarily have a transform style on it, since we
don't blend properties in
> +	   software as the animation progresses. Instead, all of the blending
is performed by the compositor,
> +	   and only the computed style object has the software-blended
transform style on it.
> +
> +	   * css/CSSComputedStyleDeclaration.cpp:
> +	   (WebCore::computedTransform):

None of this explains why there is also a change that RenderInline objects
can't have a computed transform.