[webkit-reviews] review granted: [Bug 183930] Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebCore : [Attachment 336356] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 22 23:15:59 PDT 2018


mitz at webkit.org has granted Tim Horton <thorton at apple.com>'s request for
review:
Bug 183930: Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebCore
https://bugs.webkit.org/show_bug.cgi?id=183930

Attachment 336356: Patch

https://bugs.webkit.org/attachment.cgi?id=336356&action=review




--- Comment #3 from mitz at webkit.org ---
Comment on attachment 336356
  --> https://bugs.webkit.org/attachment.cgi?id=336356
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336356&action=review

> Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:9910
> +			shellScript = "set -e\n\nif [[ -f
\"${BUILT_PRODUCTS_DIR}${WK_ALTERNATE_WEBKIT_SDK_PATH}/libWTF.a\" ]]; then\n   
ln -s -f -h \"${BUILT_PRODUCTS_DIR}${WK_ALTERNATE_WEBKIT_SDK_PATH}/libWTF.a\"
\"${BUILT_PRODUCTS_DIR}/DerivedSources/JavaScriptCore/libWTF.a\"\nelse\n    ln
-s -f -h \"${SDK_DIR}${WK_ALTERNATE_WEBKIT_SDK_PATH}/usr/local/lib/libWTF.a\"
\"${BUILT_PRODUCTS_DIR}/DerivedSources/JavaScriptCore/libWTF.a\"\nfi";

Oops!


More information about the webkit-reviews mailing list