[webkit-reviews] review denied: [Bug 183923] The layout test fast/canvas/webgl/read-pixels-test.html is timing out. : [Attachment 336325] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 22 16:33:41 PDT 2018


Tim Horton <thorton at apple.com> has denied Per Arne Vollan <pvollan at apple.com>'s
request for review:
Bug 183923: The layout test fast/canvas/webgl/read-pixels-test.html is timing
out.
https://bugs.webkit.org/show_bug.cgi?id=183923

Attachment 336325: Patch

https://bugs.webkit.org/attachment.cgi?id=336325&action=review




--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 336325
  --> https://bugs.webkit.org/attachment.cgi?id=336325
Patch

I assume there's a reason that we're not setting this bit if we don't have a
mux-capable GPU, and also this is not the only caller of that function. We need
to carefully consider each caller and what it means if this function now lies.


More information about the webkit-reviews mailing list