[webkit-reviews] review granted: [Bug 183796] Lint web-platform-tests changes with the wpt linter before exporting : [Attachment 336294] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Brendan McLoughlin
<brendan at bocoup.com>'s request for review:
Bug 183796: Lint web-platform-tests changes with the wpt linter before
exporting
https://bugs.webkit.org/show_bug.cgi?id=183796

Attachment 336294: Patch

https://bugs.webkit.org/attachment.cgi?id=336294&action=review




--- Comment #12 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 336294
  --> https://bugs.webkit.org/attachment.cgi?id=336294
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336294&action=review

> Tools/Scripts/webkitpy/w3c/wpt_linter.py:31
> +    calls = []

Probably not needed.

> Tools/Scripts/webkitpy/w3c/wpt_linter.py:37
> +	   cmd = [self.repository_directory + '/wpt', 'lint']

We usually use webkitpy filesystem.join to concat paths appropriately.
Maybe you could pass the filesystem to the constructor and build the path
there.