[webkit-reviews] review canceled: [Bug 183913] Include security origin in the service worker process name : [Attachment 336298] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has canceled Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 183913: Include security origin in the service worker process name
https://bugs.webkit.org/show_bug.cgi?id=183913

Attachment 336298: Patch

https://bugs.webkit.org/attachment.cgi?id=336298&action=review




--- Comment #4 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 336298
  --> https://bugs.webkit.org/attachment.cgi?id=336298
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336298&action=review

>>> Source/WebKit/ChangeLog:9
>>> +	     can differentiate which service worker process is used for which
origin in activity monitor.
>> 
>> Is there a privacy concern here, like some application running in the device
that could easily detect at any time whether the user is browsing to a given
origin or not?
> 
> We already display the origin for WebProcess so I do not think service
workers are any different. That said, I haven't found the code that shows the
WebProcess url in activity monitor yet.

Looks like it is done slightly differently for WebProcesses via
WebProcess::updateActivePages(). I'll see if I can do the same.