[webkit-reviews] review granted: [Bug 183806] Create an assertion mechanism to ensure proper WebCore use in each WebKit Process : [Attachment 336178] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 183806: Create an assertion mechanism to ensure proper WebCore use in each
WebKit Process
https://bugs.webkit.org/show_bug.cgi?id=183806

Attachment 336178: Patch

https://bugs.webkit.org/attachment.cgi?id=336178&action=review




--- Comment #4 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 336178
  --> https://bugs.webkit.org/attachment.cgi?id=336178
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336178&action=review

r=me with the use of OptionSet.

> Source/WTF/wtf/ProcessPrivilege.h:39
> +WTF_EXPORT void setProcessPrivileges(unsigned /* bitmap of privileges */);
> +WTF_EXPORT bool hasProcessPrivilege(ProcessPrivilege);

Please use OptionSet<ProcessPrivilege>.