[webkit-reviews] review granted: [Bug 183864] [Web Animations] Ensure animationcancel and transitioncancel events are dispatched : [Attachment 336223] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 183864: [Web Animations] Ensure animationcancel and transitioncancel events
are dispatched
https://bugs.webkit.org/show_bug.cgi?id=183864

Attachment 336223: Patch

https://bugs.webkit.org/attachment.cgi?id=336223&action=review




--- Comment #2 from Dean Jackson <dino at apple.com> ---
Comment on attachment 336223
  --> https://bugs.webkit.org/attachment.cgi?id=336223
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336223&action=review

> Source/WebCore/animation/AnimationTimeline.cpp:139
> +    if (oldStyle && oldStyle->hasAnimations() && oldStyle->display() != NONE
&& newStyle.display() == NONE) {

At some point, we should get rid of this NONE value for display and use a
better enum.