[webkit-reviews] review granted: [Bug 183855] Compile error when not using IOSurface canvas backing store. : [Attachment 336198] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 21 09:32:06 PDT 2018


Brent Fulgham <bfulgham at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 183855: Compile error when not using IOSurface canvas backing store.
https://bugs.webkit.org/show_bug.cgi?id=183855

Attachment 336198: Patch

https://bugs.webkit.org/attachment.cgi?id=336198&action=review




--- Comment #2 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 336198
  --> https://bugs.webkit.org/attachment.cgi?id=336198
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336198&action=review

> Source/WebCore/platform/graphics/cocoa/IOSurface.mm:115
> +#endif

You should probably make this change in the header, too. We do so for "#if
HAVE(IOSURFACE_ACCELERATOR)", for example, and in ImageBufferDataCG.h.


More information about the webkit-reviews mailing list