[webkit-reviews] review granted: [Bug 183658] [iOS] Text highlighted by the Find UI overlaps with NBC news header on google.com : [Attachment 335937] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Frédéric Wang (:fredw)
<fred.wang at free.fr>'s request for review:
Bug 183658: [iOS] Text highlighted by the Find UI overlaps with NBC news header
on google.com
https://bugs.webkit.org/show_bug.cgi?id=183658

Attachment 335937: Patch

https://bugs.webkit.org/attachment.cgi?id=335937&action=review




--- Comment #4 from Tim Horton <thorton at apple.com> ---
Comment on attachment 335937
  --> https://bugs.webkit.org/attachment.cgi?id=335937
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335937&action=review

> Source/WebKit/WebProcess/WebPage/ios/FindControllerIOS.mm:163
> +    // On Mobile, many sites have overlay headers or footers that may
overlap with the highlighted

I don’t love this comment, since fixed bars are not unique to “mobile”.

The ideal fix here would of course be to scroll as little as possible while
avoiding fixedpos things, but I imagine that is quite hard. I guess this is a
reasonable change in the meantime.