[webkit-reviews] review granted: [Bug 183808] Update the DYLD install name for frameworks built with WK_ALTERNATE_FRAMEWORKS_DIR : [Attachment 336179] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 20 22:48:45 PDT 2018


mitz at webkit.org has granted Tim Horton <thorton at apple.com>'s request for
review:
Bug 183808: Update the DYLD install name for frameworks built with
WK_ALTERNATE_FRAMEWORKS_DIR
https://bugs.webkit.org/show_bug.cgi?id=183808

Attachment 336179: Patch

https://bugs.webkit.org/attachment.cgi?id=336179&action=review




--- Comment #3 from mitz at webkit.org ---
Comment on attachment 336179
  --> https://bugs.webkit.org/attachment.cgi?id=336179
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336179&action=review

> Source/JavaScriptCore/ChangeLog:3
> +	   Update the DYLD install name for frameworks built with
WK_ALTERNATE_FRAMEWORKS_DIR

s/DYLD //. Also, you say “frameworks” but only change one framework. Are you
going to use this bug for more patches?


More information about the webkit-reviews mailing list