[webkit-reviews] review granted: [Bug 183804] Don't use the presence of a textSelectionAssistant as a proxy for if we are in content editable. : [Attachment 336171] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 183804: Don't use the presence of a textSelectionAssistant as a proxy for
if we are in content editable.
https://bugs.webkit.org/show_bug.cgi?id=183804

Attachment 336171: Patch

https://bugs.webkit.org/attachment.cgi?id=336171&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 336171
  --> https://bugs.webkit.org/attachment.cgi?id=336171
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336171&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1525
> +	   // Send and async message to find out.

s/and/an/

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1637
> +    // if we're selecting something, don't activate highlight

Comments are complete sentences with capitals and punctuation.