[webkit-reviews] review granted: [Bug 168622] Web Inspector: Session dividers are not added when Console tab is not visible : [Attachment 335909] Patch

[bugzilla-daemon at webkit.org]

Matt Baker <mattbaker at apple.com> has granted Devin Rousso
<webkit at devinrousso.com>'s request for review:
Bug 168622: Web Inspector: Session dividers are not added when Console tab is
not visible
https://bugs.webkit.org/show_bug.cgi?id=168622

Attachment 335909: Patch

https://bugs.webkit.org/attachment.cgi?id=335909&action=review




--- Comment #3 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 335909
  --> https://bugs.webkit.org/attachment.cgi?id=335909
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335909&action=review

Works great, r=me with some minor style comments:

it feel wrong to use the name `this._currentConsoleGroup`, when the value is
always a ConsoleSession object. I know it was already like this, but I think
this would be a good time to change the name.

Also, the public properties `prompt` and `currentConsoleGroup` are not
referenced anywhere, and can be removed.

>
Source/WebInspectorUI/UserInterface/Controllers/JavaScriptLogViewController.js:
62
> +	   this._pendingMessages = new Map;

I think `this._pendingMessageViewsForSession` would be more self-explanatory.