[webkit-reviews] review granted: [Bug 182619] Web Inspector: Styles: Loses focus when editing a property while page is being loaded : [Attachment 335815] Patch

[bugzilla-daemon at webkit.org]

Matt Baker <mattbaker at apple.com> has granted Timothy Hatcher
<timothy at apple.com>'s request for review:
Bug 182619: Web Inspector: Styles: Loses focus when editing a property while
page is being loaded
https://bugs.webkit.org/show_bug.cgi?id=182619

Attachment 335815: Patch

https://bugs.webkit.org/attachment.cgi?id=335815&action=review




--- Comment #12 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 335815
  --> https://bugs.webkit.org/attachment.cgi?id=335815
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335815&action=review

r=me

> Source/WebInspectorUI/ChangeLog:11
> +	   selection, and completion.

I think this could be reworded as:

Adding or removing a stylesheet causes SpreadsheetRulesStyleDetailsPanel to
refresh, triggering a layout of all SpreadsheetCSSStyleDeclarationSection child
views. This resets the focus, selection, and auto-completion state.

> Source/WebInspectorUI/ChangeLog:13
> +	   This patch prevents re-layouts of
SpreadsheetCSSStyleDeclarationSection when its CSS properties are being edited.

And:

This patch prevents SpreadsheetCSSStyleDeclarationSection from performing a
layout when a property is being edited.

>
Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.
js:65
> +	   // Don't re-layout all properties when one of them is being edited.
Full re-layout resets

"re-layout" is awkward. What about:

// Prevent layout of properties when one of them is being edited. A full layout
resets...