[webkit-reviews] review granted: [Bug 183758] Add and adopt WK_PLATFORM_NAME and adjust default feature defines : [Attachment 336133] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 20 11:00:28 PDT 2018


mitz at webkit.org has granted Tim Horton <thorton at apple.com>'s request for
review:
Bug 183758: Add and adopt WK_PLATFORM_NAME and adjust default feature defines
https://bugs.webkit.org/show_bug.cgi?id=183758

Attachment 336133: Patch

https://bugs.webkit.org/attachment.cgi?id=336133&action=review




--- Comment #12 from mitz at webkit.org ---
Comment on attachment 336133
  --> https://bugs.webkit.org/attachment.cgi?id=336133
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336133&action=review

> Source/WTF/wtf/FeatureDefines.h:236
> +#if ENABLE(MINIMAL_SIMULATOR)
> +
> +#if !defined(ENABLE_LEGACY_ENCRYPTED_MEDIA)
> +#define ENABLE_LEGACY_ENCRYPTED_MEDIA 0
> +#endif
> +
> +#endif /* ENABLE(MINIMAL_SIMULATOR) */

Makes more sense to move this into the #if
!defined(ENABLE_LEGACY_ENCRYPTED_MEDIA) below.


More information about the webkit-reviews mailing list