[webkit-reviews] review granted: [Bug 183590] [DFG][FTL] Make ArraySlice(0) code tight : [Attachment 335688] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 183590: [DFG][FTL] Make ArraySlice(0) code tight
https://bugs.webkit.org/show_bug.cgi?id=183590

Attachment 335688: Patch

https://bugs.webkit.org/attachment.cgi?id=335688&action=review




--- Comment #5 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 335688
  --> https://bugs.webkit.org/attachment.cgi?id=335688
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335688&action=review

> Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:1079
> +		   fixEdge<Int32Use>(m_graph.varArgChild(node, 1));

Don’t you want to do this if count >= 2?

> Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:1080
> +		   if (node->numChildren() == 4)

Ignore above comment (bugzilla on my phone is not allowing me to delete the
above comment). I misread the code.