[webkit-reviews] review granted: [Bug 183694] [DFG][FTL] Add vectorLengthHint for NewArray : [Attachment 335928] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 183694: [DFG][FTL] Add vectorLengthHint for NewArray
https://bugs.webkit.org/show_bug.cgi?id=183694

Attachment 335928: Patch

https://bugs.webkit.org/attachment.cgi?id=335928&action=review




--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 335928
  --> https://bugs.webkit.org/attachment.cgi?id=335928
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335928&action=review

r=me

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp:3734
> +	       ASSERT(vectorLengthHint >= numElements);

I’d make this a validation rule