[webkit-reviews] review granted: [Bug 183759] Clear style colors when setting default appearance : [Attachment 336093] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 19 19:03:24 PDT 2018


Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 183759: Clear style colors when setting default appearance
https://bugs.webkit.org/show_bug.cgi?id=183759

Attachment 336093: Patch

https://bugs.webkit.org/attachment.cgi?id=336093&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 336093
  --> https://bugs.webkit.org/attachment.cgi?id=336093
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336093&action=review

> Source/WebKitLegacy/mac/WebView/WebView.mm:5202
> +- (void)_setDefaultAppearanceAndClearStyle

I think this is “update”, not “set”, because it takes no arguments. And you can
leave the clearStyle bit off


More information about the webkit-reviews mailing list