[webkit-reviews] review granted: [Bug 183753] Have select element respect current appearance : [Attachment 336088] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 19 18:15:16 PDT 2018


Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 183753: Have select element respect current appearance
https://bugs.webkit.org/show_bug.cgi?id=183753

Attachment 336088: Patch

https://bugs.webkit.org/attachment.cgi?id=336088&action=review




--- Comment #6 from Tim Horton <thorton at apple.com> ---
Comment on attachment 336088
  --> https://bugs.webkit.org/attachment.cgi?id=336088
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336088&action=review

> Source/WebCore/rendering/RenderThemeMac.mm:1350
> +	   c = !e->isDisabledFormControl() ? systemColor(CSSValueButtontext,
e->document().page()->useSystemAppearance()) : systemColor(CSSValueGraytext,
e->document().page()->useSystemAppearance());

Pop useSystemAppearance into a local


More information about the webkit-reviews mailing list