[webkit-reviews] review granted: [Bug 183753] Have select element respect current appearance : [Attachment 336087] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 183753: Have select element respect current appearance
https://bugs.webkit.org/show_bug.cgi?id=183753

Attachment 336087: Patch

https://bugs.webkit.org/attachment.cgi?id=336087&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 336087
  --> https://bugs.webkit.org/attachment.cgi?id=336087
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336087&action=review

> Source/WebCore/rendering/RenderThemeMac.mm:1348
> +    style.setColor(e ? !e->isDisabledFormControl() ?
systemColor(CSSValueButtontext, e->document().page()->useSystemAppearance()) :
systemColor(CSSValueGraytext, e->document().page()->useSystemAppearance()) :
Color::darkGray);

The logic here (nested ternary operators) is incredibly hard to follow. Can we
pop it out into a few lines instead?