[webkit-reviews] review denied: [Bug 183696] Use --relative git parameter when applicable to generate WPT patch : [Attachment 336041] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Brendan McLoughlin
<brendan at bocoup.com>'s request for review:
Bug 183696: Use --relative git parameter when applicable to generate WPT patch
https://bugs.webkit.org/show_bug.cgi?id=183696

Attachment 336041: Patch

https://bugs.webkit.org/attachment.cgi?id=336041&action=review




--- Comment #6 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 336041
  --> https://bugs.webkit.org/attachment.cgi?id=336041
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336041&action=review

r- because SVN implementation is inadequate.

> Tools/Scripts/webkitpy/common/checkout/scm/svn.py:303
> +	       relative_path = relative if relative.endswith('/') else relative
+ '/'
> +	       patch = patch.replace(relative_path, '')

This would replace any string which contains this string. That could be
problematic inside Source.
Do a regex match against file names protruded in lines 392-395 in
./Tools/Scripts/svn-create-patch

But a better fix is to add an option to svn-create-patch to specify a relative
path as you've done to git.