[webkit-reviews] review denied: [Bug 183605] [WinCairo] Fix incompatibility of run-webkit-httpd on native Windows. : [Attachment 335893] PATCH

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has denied  review:
Bug 183605: [WinCairo] Fix incompatibility of run-webkit-httpd on native
Windows.
https://bugs.webkit.org/show_bug.cgi?id=183605

Attachment 335893: PATCH

https://bugs.webkit.org/attachment.cgi?id=335893&action=review




--- Comment #19 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 335893
  --> https://bugs.webkit.org/attachment.cgi?id=335893
PATCH

View in context: https://bugs.webkit.org/attachment.cgi?id=335893&action=review

> Tools/Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:124
> +	   temp_file.close()

We are underutilizing the purpose of tempfile.NamedTemporaryFile() by closing
it. In particular, the only benefit we are gaining here is that
tempfile.NamedTemporaryFile() picks a path inside the system's temporary
directory. However, this path could be reused by the OS between the time when
we delete the file (implicitly when we call close()) and when Apache tries to
open the file for write. Moreover, we never unlink the file after Apache is
done. I suggest that we make use of FileSystem to create a temporary directory
then create a normal file inside that directory and give the path to that file
to Apache and tail.