[webkit-reviews] review granted: [Bug 183742] [Extra zoom mode] Require fullscreen for video playback : [Attachment 336044] Patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted  review:
Bug 183742: [Extra zoom mode] Require fullscreen for video playback
https://bugs.webkit.org/show_bug.cgi?id=183742

Attachment 336044: Patch

https://bugs.webkit.org/attachment.cgi?id=336044&action=review




--- Comment #5 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 336044
  --> https://bugs.webkit.org/attachment.cgi?id=336044
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336044&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:5272
> -	       if (m_mediaSession->requiresFullscreenForVideoPlayback(*this) &&
!isFullscreen())
> +	       if (m_mediaSession->requiresFullscreenForVideoPlayback(*this) &&
!isFullscreen()) {
>		   enterFullscreen();
> +#if ENABLE(EXTRA_ZOOM_MODE)
> +		   return;
> +#endif
> +	       }

Why not just make the early return unconditional? Then this could be moved
outside the if() statement; mitigating any side effects to things like
"setDisplayMode()" and "clientWillBeginPlayback()".