[webkit-reviews] review granted: [Bug 183604] When the WebContent process is blocked from accessing the WindowServer, the call CVDisplayLinkCreateWithCGDisplay will fail. : [Attachment 336007] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 183604: When the WebContent process is blocked from accessing the
WindowServer, the call CVDisplayLinkCreateWithCGDisplay will fail.
https://bugs.webkit.org/show_bug.cgi?id=183604

Attachment 336007: Patch

https://bugs.webkit.org/attachment.cgi?id=336007&action=review




--- Comment #28 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 336007
  --> https://bugs.webkit.org/attachment.cgi?id=336007
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336007&action=review

Looks good. Please keep an eye on the performance bots to make sure we don't
regress anything.

> Source/WebCore/ChangeLog:10
> +	   about display updates, by sending a message from the UIProcess on
each screen update. This patch adds an extra

No comma needed here: "... about display updates by sending a message..."

> Source/WebKit/UIProcess/mac/DisplayLink.cpp:48
> +	   WTFLogAlways("Could not create a display link: %d", error);

"Could not set the display link output callback: %d"

> Source/WebKit/UIProcess/mac/DisplayLink.cpp:54
> +	   WTFLogAlways("Could not create a display link: %d", error);

"Could not start the display link: %d"