[webkit-reviews] review granted: [Bug 183706] Add _useSystemAppearance to WKView : [Attachment 335968] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Mar 16 15:12:15 PDT 2018
Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 183706: Add _useSystemAppearance to WKView
https://bugs.webkit.org/show_bug.cgi?id=183706
Attachment 335968: Patch
https://bugs.webkit.org/attachment.cgi?id=335968&action=review
--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 335968
--> https://bugs.webkit.org/attachment.cgi?id=335968
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=335968&action=review
LGTM. Technically we could probably share the implementation of the
defaultAppearance getter in WebViewImpl as well, but that’s just cleanup
> Source/WebKit/UIProcess/API/Cocoa/WKViewPrivate.h:142
> + at property (nonatomic, readwrite, setter=_setUseSystemAppearance:) BOOL
_useSystemAppearance WK_API_AVAILABLE(macosx(WK_MAC_TBA));
Maybe a newline before this.
More information about the webkit-reviews
mailing list