[webkit-reviews] review granted: [Bug 183708] Web Inspector: Elements: "Force Print Media Styles" should not persist across Web Inspector sessions : [Attachment 335971] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 16 14:59:29 PDT 2018


Matt Baker <mattbaker at apple.com> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 183708: Web Inspector: Elements: "Force Print Media Styles" should not
persist across Web Inspector sessions
https://bugs.webkit.org/show_bug.cgi?id=183708

Attachment 335971: Patch

https://bugs.webkit.org/attachment.cgi?id=335971&action=review




--- Comment #4 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 335971
  --> https://bugs.webkit.org/attachment.cgi?id=335971
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335971&action=review

r=me

> Source/WebInspectorUI/UserInterface/Base/Main.js:182
> +    this.printStylesEnabled = false;

This could be a static property of DOMTreeContentView, since it's now the only
place it's used. But I'll leave it up to you.


More information about the webkit-reviews mailing list