[webkit-reviews] review denied: [Bug 183681] webkitpy: Unrecognized mac versions always use WebKitTestRunner : [Attachment 335938] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has denied Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 183681: webkitpy: Unrecognized mac versions always use WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=183681

Attachment 335938: Patch

https://bugs.webkit.org/attachment.cgi?id=335938&action=review




--- Comment #6 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 335938
  --> https://bugs.webkit.org/attachment.cgi?id=335938
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335938&action=review

> Tools/Scripts/webkitpy/port/apple.py:68
> -		   port_name = cls.port_name + '-wk2'
> +		   port_name = cls.port_name

r-, this is not correct and still disagrees with the comment above this code as
I said in comment #3. Take port_name to be "mac-wk2" and cls.port_name to be
"mac" and assume there is no name for the os version the machine is using.