[webkit-reviews] review granted: [Bug 183690] Ensure that style is updated when the effective appearance changes : [Attachment 335922] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 183690: Ensure that style is updated when the effective appearance changes
https://bugs.webkit.org/show_bug.cgi?id=183690

Attachment 335922: Patch

https://bugs.webkit.org/attachment.cgi?id=335922&action=review




--- Comment #4 from Tim Horton <thorton at apple.com> ---
Comment on attachment 335922
  --> https://bugs.webkit.org/attachment.cgi?id=335922
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335922&action=review

> Source/WebCore/ChangeLog:9
> +	   Only exposing a function to outside webcore, no tests needed.

WebCore

>> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:6188
>> +	_page->updateForAppearanceChange();
> 
> Instead of propagating another IPC message, could we just
setNeedsRecalcStyleInAllFrames() after setting the default appearance in the
web process?

Agree! Tinier patch.

> Source/WebKitLegacy/mac/WebView/WebView.mm:5216
> +#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400

Not really necessary.

> Source/WebKitLegacy/mac/WebView/WebView.mm:5219
> +    if (auto page = _private->page) {

Early return instead of this.