[webkit-reviews] review granted: [Bug 183686] [Curl] Fix crash on websocket with bad handshake message. : [Attachment 335913] PATCH

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 15 22:10:43 PDT 2018


youenn fablet <youennf at gmail.com> has granted Basuke Suzuki
<Basuke.Suzuki at sony.com>'s request for review:
Bug 183686: [Curl] Fix crash on websocket with bad handshake message.
https://bugs.webkit.org/show_bug.cgi?id=183686

Attachment 335913: PATCH

https://bugs.webkit.org/attachment.cgi?id=335913&action=review




--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 335913
  --> https://bugs.webkit.org/attachment.cgi?id=335913
PATCH

View in context: https://bugs.webkit.org/attachment.cgi?id=335913&action=review

> Source/WebCore/platform/network/curl/SocketStreamHandleImplCurl.cpp:94
> +    m_closed = true;

In case platformClose() needs to be called elsewhere in the future, we could
rewrite it as:
if (m_closed)
     return;
m_closed = true;
...


More information about the webkit-reviews mailing list