[webkit-reviews] review granted: [Bug 183675] Add and adopt WK_ALTERNATE_FRAMEWORKS_DIR in ANGLE : [Attachment 335879] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Tim Horton <thorton at apple.com>'s request for
review:
Bug 183675: Add and adopt WK_ALTERNATE_FRAMEWORKS_DIR in ANGLE
https://bugs.webkit.org/show_bug.cgi?id=183675

Attachment 335879: Patch

https://bugs.webkit.org/attachment.cgi?id=335879&action=review




--- Comment #4 from mitz at webkit.org ---
Comment on attachment 335879
  --> https://bugs.webkit.org/attachment.cgi?id=335879
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335879&action=review

> Source/ThirdParty/ANGLE/Configurations/Base.xcconfig:76
> +ANGLE_INSTALL_PATH_PREFIX_YES = $(WK_ALTERNATE_FRAMEWORKS_DIR)/;

Why the trailing / here? You seem to not need it in all use sites.