[webkit-reviews] review granted: [Bug 183663] REGRESSION(r229484): Plugins often require CGS Connections to draw : [Attachment 335857] Patch

[bugzilla-daemon at webkit.org]

Per Arne Vollan <pvollan at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 183663: REGRESSION(r229484): Plugins often require CGS Connections to draw
https://bugs.webkit.org/show_bug.cgi?id=183663

Attachment 335857: Patch

https://bugs.webkit.org/attachment.cgi?id=335857&action=review




--- Comment #5 from Per Arne Vollan <pvollan at apple.com> ---
Comment on attachment 335857
  --> https://bugs.webkit.org/attachment.cgi?id=335857
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335857&action=review

R=me.

>>> Source/WebKit/Platform/mac/LayerHostingContext.mm:81
>>> +	 layerHostingContext->m_context = [CAContext
contextWithCGSConnection:CGSMainConnectionID() options:@{
kCAContextCIFilterBehavior : @"ignore" }];
>> 
>> Will creating the context with 'layerHostingContext->m_context = [CAContext
remoteContextWithOptions:@{kCAContextCIFilterBehavior :  @"ignore"}];' work?
> 
> No -- I tried that first and it failed.

Ah, right. I first thought it was the call '[CAContext
setAllowsCGSConnections:NO];' that made this fail for the Plugin process.