[webkit-reviews] review granted: [Bug 183649] Add and adopt WK_ALTERNATE_FRAMEWORKS_DIR in JavaScriptCore : [Attachment 335821] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Tim Horton <thorton at apple.com>'s request for
review:
Bug 183649: Add and adopt WK_ALTERNATE_FRAMEWORKS_DIR in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=183649

Attachment 335821: Patch

https://bugs.webkit.org/attachment.cgi?id=335821&action=review




--- Comment #3 from mitz at webkit.org ---
Comment on attachment 335821
  --> https://bugs.webkit.org/attachment.cgi?id=335821
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335821&action=review

r=me but prefer the minimalistic version

> Source/JavaScriptCore/Configurations/Base.xcconfig:94
> +HEADER_SEARCH_PATHS = .
"${BUILT_PRODUCTS_DIR}${WK_ALTERNATE_WEBKIT_SDK_PATH}/usr/local/include"
$(HEADER_SEARCH_PATHS);

Good opportunity to change that trailing $(HEADER_SEARCH_PATHS) to $(inherited)

> Source/JavaScriptCore/Configurations/Base.xcconfig:95
> +SYSTEM_HEADER_SEARCH_PATHS =
$(SDK_DIR)$(WK_ALTERNATE_WEBKIT_SDK_PATH)/usr/local/include $(inherited);

I think this might not be needed—anytime WK_ALTERNATE_WEBKIT_SDK_PATH is set,
something external to the project is going to include this in
SYSTEM_HEADER_SEARCH_PATHS.

> Source/JavaScriptCore/Configurations/Base.xcconfig:96
> +LIBRARY_SEARCH_PATHS =
$(SDK_DIR)$(WK_ALTERNATE_WEBKIT_SDK_PATH)/usr/local/lib $(inherited);

Ditto.