[webkit-reviews] review granted: [Bug 183647] Web Inspector: Canvas: a recording initiated by the user should be shown immediately on completion : [Attachment 335813] Patch

[bugzilla-daemon at webkit.org]

Matt Baker <mattbaker at apple.com> has granted Devin Rousso
<webkit at devinrousso.com>'s request for review:
Bug 183647: Web Inspector: Canvas: a recording initiated by the user should be
shown immediately on completion
https://bugs.webkit.org/show_bug.cgi?id=183647

Attachment 335813: Patch

https://bugs.webkit.org/attachment.cgi?id=335813&action=review




--- Comment #3 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 335813
  --> https://bugs.webkit.org/attachment.cgi?id=335813
Patch

r=me. A top-level comment about *why* this fixes the issue would be nice. I had
to do some debugging to learn that CanvasManager was dispatching
RecordingStopped with `fromConsole` set to true, because this._recordingCanvas
was being nulled out too early.