[webkit-reviews] review granted: [Bug 183644] MessagePort should remove its listeners when being closed : [Attachment 335797] Patch

Wed Mar 14 14:24:22 PDT 2018

Chris Dumez <cdumez at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 183644: MessagePort should remove its listeners when being closed
https://bugs.webkit.org/show_bug.cgi?id=183644

Attachment 335797: Patch

https://bugs.webkit.org/attachment.cgi?id=335797&action=review

--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 335797
  --> https://bugs.webkit.org/attachment.cgi?id=335797
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335797&action=review

r=me if the bots are happy.

> LayoutTests/http/tests/workers/worker-messageport.html:1
> +<body>

Missing <html> since you have a </html>

> LayoutTests/http/tests/workers/worker-messageport.html:14
> +	   // do GC in worker

This comment seems weird.