[webkit-reviews] review granted: [Bug 183602] imported/w3c/web-platform-tests/WebCryptoAPI/wrapKey_unwrapKey/wrapKey_unwrapKey.worker.html is crashing : [Attachment 335790] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 183602:
imported/w3c/web-platform-tests/WebCryptoAPI/wrapKey_unwrapKey/wrapKey_unwrapKe
y.worker.html is crashing
https://bugs.webkit.org/show_bug.cgi?id=183602

Attachment 335790: Patch

https://bugs.webkit.org/attachment.cgi?id=335790&action=review




--- Comment #21 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 335790
  --> https://bugs.webkit.org/attachment.cgi?id=335790
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335790&action=review

r=me with changes.

> Source/WebCore/dom/ScriptExecutionContext.cpp:119
> +    if (m_contextIdentifier.toUInt64()) {

if (m_contextIdentifier) {

> Source/WebCore/dom/ScriptExecutionContext.cpp:122
> +	       "ScriptExecution subclass implementing postTask should have
already removed itself from the map");

This assertion message does not make sense here.

> Source/WebCore/dom/ScriptExecutionContext.cpp:156
> +    if (m_contextIdentifier.toUInt64()) {

if (m_contextIdentifier) {

> Source/WebCore/dom/ScriptExecutionContext.cpp:158
> +	  
ASSERT(!allScriptExecutionContextsMap().contains(m_contextIdentifier));

This is the assertion that should have been an ASSERT_WITH_MESSAGE() and which
should have used the message above.