[webkit-reviews] review granted: [Bug 183626] Reduce use of SWServerToContextConnection::globalServerToContextConnection() : [Attachment 335779] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 183626: Reduce use of
SWServerToContextConnection::globalServerToContextConnection()
https://bugs.webkit.org/show_bug.cgi?id=183626

Attachment 335779: Patch

https://bugs.webkit.org/attachment.cgi?id=335779&action=review




--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 335779
  --> https://bugs.webkit.org/attachment.cgi?id=335779
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335779&action=review

> Source/WebKit/StorageProcess/ServiceWorker/WebSWServerConnection.cpp:202
> +    server().runServiceWorkerIfNecessary(destinationIdentifier,
[destinationIdentifier, message = WTFMove(message), sourceData =
WTFMove(*sourceData)](bool success, auto* contextConnection) mutable {

Can we get rid of success if we now pass a pointer?