[webkit-reviews] review granted: [Bug 183610] fast/loader/javascript-url-iframe-remove-on-navigate.html is a flaky crash on iOS with async delegates : [Attachment 335744] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 13 16:39:34 PDT 2018


youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 183610: fast/loader/javascript-url-iframe-remove-on-navigate.html is a
flaky crash on iOS with async delegates
https://bugs.webkit.org/show_bug.cgi?id=183610

Attachment 335744: Patch

https://bugs.webkit.org/attachment.cgi?id=335744&action=review




--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 335744
  --> https://bugs.webkit.org/attachment.cgi?id=335744
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335744&action=review

> Source/WebCore/ChangeLog:9
> +	   return null due to the load getting cancelled synchronously. If this
load the parent frame's last

s/load/load is/

> Source/WebCore/ChangeLog:15
> +	   which crashes flakily.

crashes/crashed

> Source/WebCore/loader/DocumentLoader.cpp:1725
> +	       return;

I wonder whether some housekeeping would be good to do, hopefully not but
hey...
For instance, is m_loadingMainResource false when returning early (hopefully
yes)?

> Source/WebCore/loader/DocumentLoader.cpp:1728
>	       RELEASE_LOG_IF_ALLOWED("startLoadingMainResource: Unable to load
main resource, URL is invalid (frame = %p, main = %d)", m_frame,
m_frame->isMainFrame());

I wonder whether we would still want to log this error case even in the case
frame is null?


More information about the webkit-reviews mailing list