[webkit-reviews] review requested: [Bug 183602] imported/w3c/web-platform-tests/WebCryptoAPI/wrapKey_unwrapKey/wrapKey_unwrapKey.worker.html is crashing : [Attachment 335725] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has asked  for review:
Bug 183602:
imported/w3c/web-platform-tests/WebCryptoAPI/wrapKey_unwrapKey/wrapKey_unwrapKe
y.worker.html is crashing
https://bugs.webkit.org/show_bug.cgi?id=183602

Attachment 335725: Patch

https://bugs.webkit.org/attachment.cgi?id=335725&action=review




--- Comment #7 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 335725
  --> https://bugs.webkit.org/attachment.cgi?id=335725
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335725&action=review

> Source/WebCore/crypto/CryptoAlgorithm.cpp:99
> +	   [operation = WTFMove(operation), callback = WTFMove(callback),
exceptionCallback = WTFMove(exceptionCallback), identifier =
context.contextIdentifier()]() mutable {

I think contextIdentifier would be a better name than identifier here.

> Source/WebCore/crypto/algorithms/CryptoAlgorithmECDH.cpp:120
> +	   [baseKey = WTFMove(baseKey), publicKey =
ecParameters.publicKey.releaseNonNull(), length, unifiedCallback =
WTFMove(unifiedCallback), identifier = context.contextIdentifier()]() mutable {

ditto.

> Source/WebCore/crypto/algorithms/CryptoAlgorithmSHA1.cpp:54
> +    workQueue.dispatch([digest = WTFMove(digest), message =
WTFMove(message), callback = WTFMove(callback), identifier =
context.contextIdentifier()]() mutable {

ditto.

> Source/WebCore/crypto/algorithms/CryptoAlgorithmSHA224.cpp:54
> +    workQueue.dispatch([digest = WTFMove(digest), message =
WTFMove(message), callback = WTFMove(callback), identifier =
context.contextIdentifier()]() mutable {

ditto.

> Source/WebCore/crypto/algorithms/CryptoAlgorithmSHA256.cpp:54
> +    workQueue.dispatch([digest = WTFMove(digest), message =
WTFMove(message), callback = WTFMove(callback), identifier =
context.contextIdentifier()]() mutable {

ditto.

> Source/WebCore/crypto/algorithms/CryptoAlgorithmSHA384.cpp:54
> +    workQueue.dispatch([digest = WTFMove(digest), message =
WTFMove(message), callback = WTFMove(callback), identifier =
context.contextIdentifier()]() mutable {

ditto.

> Source/WebCore/crypto/algorithms/CryptoAlgorithmSHA512.cpp:54
> +    workQueue.dispatch([digest = WTFMove(digest), message =
WTFMove(message), callback = WTFMove(callback), identifier =
context.contextIdentifier()]() mutable {

ditto.

> Source/WebCore/crypto/mac/CryptoKeyRSAMac.cpp:296
> +    auto identifier = context->contextIdentifier();

ditto.