[webkit-reviews] review granted: [Bug 183576] Add and adopt WK_ALTERNATE_FRAMEWORKS_DIR in WTF and bmalloc : [Attachment 335733] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Tim Horton <thorton at apple.com>'s request for
review:
Bug 183576: Add and adopt WK_ALTERNATE_FRAMEWORKS_DIR in WTF and bmalloc
https://bugs.webkit.org/show_bug.cgi?id=183576

Attachment 335733: Patch

https://bugs.webkit.org/attachment.cgi?id=335733&action=review




--- Comment #10 from mitz at webkit.org ---
Comment on attachment 335733
  --> https://bugs.webkit.org/attachment.cgi?id=335733
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335733&action=review

> Source/WTF/Configurations/Base.xcconfig:93
> +HEADER_SEARCH_PATHS =
$(BUILT_PRODUCTS_DIR)/$(WTF_INSTALL_PATH_PREFIX)/usr/local/include
$(DSTROOT)/$(WTF_INSTALL_PATH_PREFIX)/usr/local/include $(HEADER_SEARCH_PATHS);

I think you can count on WTF_INSTALL_PATH_PREFIX to begin with a / if it’s
nonempty. And you may change $(HEADER_SEARCH_PATHS) to $(inherited)!

> Source/WTF/Configurations/Base.xcconfig:94
> +SYSTEM_HEADER_SEARCH_PATHS = $(inherited)
$(SDK_DIR)/$(WTF_INSTALL_PATH_PREFIX)/usr/local/include;

Don’t we want to search in the alternate location first? Things may exist in
both locations. Ditto about the leading /.

> Source/WTF/Configurations/Base.xcconfig:95
> +LIBRARY_SEARCH_PATHS = $(inherited)
$(SDK_DIR)/$(WTF_INSTALL_PATH_PREFIX)/usr/local/lib;

Ditto on both counts.