[webkit-reviews] review denied: [Bug 183386] LayoutTests/http/tests/navigation/page-cache-iframe-provisional-load.html fails with async policy delegate : [Attachment 335647] Patch for review (fixed style errors)

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has denied Danyao Wang <danyao at chromium.org>'s
request for review:
Bug 183386:
LayoutTests/http/tests/navigation/page-cache-iframe-provisional-load.html fails
with async policy delegate
https://bugs.webkit.org/show_bug.cgi?id=183386

Attachment 335647: Patch for review (fixed style errors)

https://bugs.webkit.org/attachment.cgi?id=335647&action=review




--- Comment #13 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 335647
  --> https://bugs.webkit.org/attachment.cgi?id=335647
Patch for review (fixed style errors)

View in context: https://bugs.webkit.org/attachment.cgi?id=335647&action=review

> LayoutTests/ChangeLog:15
> +	   *
http/tests/navigation/page-cache-iframe-provisional-load-async-delegates.html:
Added.

cp
LayoutTests/http/tests/navigation/page-cache-iframe-provisional-load-async-dele
gates.html
LayoutTests/http/tests/navigation/page-cache-iframe-provisional-load.html
Then fix
LayoutTests/http/tests/navigation/page-cache-iframe-provisional-load.html to
not call testRunner.setShouldDecideNavigationPolicyAfterDelay().

This way, the tests won't fail once we turn on async policy delegates by
default.